Set PYTHON_INSTALL_DIR based on Python3_SITEARCH #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python3_SIETARCH is relative, but PYTHON_INSTALL_DIR is absolute. So strip the Python3_PREFIS from Python3_SITEARCH to form a relative path. This is preferable to the current hardcoded path, but is also preferable to using an absolute path, as suggested in AcademySoftwareFoundation#523. Signed-off-by: Cary Phillips <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CMake configuration to dynamically determine the Python installation directory using Python3_SITEARCH instead of hardcoded paths. The change makes the installation path relative to Python3_PREFIX, allowing for more flexible and correct Python module installation across different systems.
Key Changes:
- Replaces hardcoded
lib/python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}/site-packagespaths with dynamically computed relative paths - Centralizes
PYTHON_INSTALL_DIRcomputation insrc/python/CMakeLists.txt - Adds fallback logic to derive
Python3_PREFIXfrom the Python executable location when not set
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/python/CMakeLists.txt | Adds logic to compute PYTHON_INSTALL_DIR as a relative path from Python3_PREFIX to Python3_SITEARCH |
| src/python/PyImath/CMakeLists.txt | Removes local PYTHON_INSTALL_DIR computation, now relies on parent CMakeLists.txt |
| src/python/PyImathNumpy/CMakeLists.txt | Removes local PYTHON_INSTALL_DIR computation, now relies on parent CMakeLists.txt |
| src/pybind11/PyBindImath/CMakeLists.txt | Updates PYTHON_INSTALL_DIR computation with the new relative path logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
merged commit 9830065
into
AcademySoftwareFoundation:main
32 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3_SIETARCH is relative, but PYTHON_INSTALL_DIR is absolute. So strip the Python3_PREFIS from Python3_SITEARCH to form a relative path.
This is preferable to the current hardcoded path, but is also preferable to using an absolute path, as suggested in #523.